Skip to content

Conversation

@willcl-ark
Copy link
Collaborator

Hey @heyolaniran, I've made a few changes to your PR in this branch, rather than force-pusing to your PR:

  • rebased on upstream/master (instead of merging master in as you did)
  • fixed up the current dependency graph as per Bitcoin Core v30/master (yours was missing new binaries and libs)

If you are happy for me to use your commits in this PR (and perhaps review it? 🙏🏼), then I'd be happy to merge this one.

Sorry for the slow review/turnaround.

heyolaniran and others added 4 commits October 2, 2025 11:39
…scription

In this commit, I've updated the dependency graph to the Bitcoin 29.0 (The actual maintained version for bitcoin Core). This graph show the entire dependencies links between various library of the code base structure.
Added the missing id tag to link the documentation to the HTML file generated by jekyll on build
@heyolaniran
Copy link
Contributor

Hello @willcl-ark , I just checked it. Thanks you for counting my commits and thanks for having time to review the work. Its good. Appreciate.

@willcl-ark
Copy link
Collaborator Author

Great, so you’re happy for me to merge this one (with your commits in) then?

@heyolaniran
Copy link
Contributor

Yes ! 😁😁. Thanks 😁 I’ll continue to learn and improve for next times😃

@willcl-ark willcl-ark merged commit f8c0fa9 into chaincodelabs:master Oct 2, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants